Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [NOMUPAY] Add template code #6382

Merged
merged 3 commits into from
Nov 12, 2024
Merged

feat(connector): [NOMUPAY] Add template code #6382

merged 3 commits into from
Nov 12, 2024

Conversation

sumanmaji4
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Template connector code for Nomupay payout

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sumanmaji4 sumanmaji4 requested review from a team as code owners October 21, 2024 13:05
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Oct 21, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/connector.rs  98% smaller
  crates/hyperswitch_connectors/src/connectors.rs  32% smaller
  crates/hyperswitch_connectors/src/default_implementations_v2.rs  19% smaller
  crates/hyperswitch_connectors/src/default_implementations.rs  19% smaller
  crates/router/src/core/payments/flows.rs  11% smaller
  crates/router/src/core/payments/connector_integration_v2_impls.rs  11% smaller
  config/config.example.toml Unsupported file format
  config/deployments/integration_test.toml Unsupported file format
  config/deployments/production.toml Unsupported file format
  config/deployments/sandbox.toml Unsupported file format
  config/development.toml Unsupported file format
  config/docker_compose.toml Unsupported file format
  crates/api_models/src/connector_enums.rs  0% smaller
  crates/common_enums/src/connector_enums.rs  0% smaller
  crates/hyperswitch_connectors/src/connectors/nomupay.rs  0% smaller
  crates/hyperswitch_connectors/src/connectors/nomupay/transformers.rs  0% smaller
  crates/hyperswitch_interfaces/src/configs.rs  0% smaller
  crates/router/src/types/api.rs  0% smaller
  crates/router/src/types/transformers.rs  0% smaller
  crates/router/tests/connectors/main.rs  0% smaller
  crates/router/tests/connectors/nomupay.rs  0% smaller
  crates/router/tests/connectors/sample_auth.toml Unsupported file format
  crates/test_utils/src/connector_auth.rs  0% smaller
  loadtest/config/development.toml Unsupported file format
  scripts/add_connector.sh Unsupported file format

@sumanmaji4 sumanmaji4 force-pushed the nomupay_payouts_connector_template branch from ba76e76 to 3494814 Compare October 22, 2024 06:14
@ImSagnik007
Copy link
Contributor

resolve the failing checks and add openapi changes as well

@sumanmaji4 sumanmaji4 force-pushed the nomupay_payouts_connector_template branch from 3494814 to 1eafd83 Compare October 22, 2024 10:01
@hyperswitch-bot hyperswitch-bot bot added M-api-contract-changes Metadata: This PR involves API contract changes and removed M-api-contract-changes Metadata: This PR involves API contract changes labels Oct 22, 2024
@sumanmaji4 sumanmaji4 self-assigned this Oct 22, 2024
@sumanmaji4 sumanmaji4 added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels Oct 22, 2024
@sumanmaji4 sumanmaji4 force-pushed the nomupay_payouts_connector_template branch from 8f397de to 047bb9d Compare October 22, 2024 12:02
@hyperswitch-bot hyperswitch-bot bot added M-api-contract-changes Metadata: This PR involves API contract changes and removed M-api-contract-changes Metadata: This PR involves API contract changes labels Oct 22, 2024
cookieg13
cookieg13 requested changes Oct 23, 2024
View reviewed changes
config/development.toml Outdated
@@ -237,6 +238,7 @@ multisafepay.base_url = "https://testapi.multisafepay.com/"
netcetera.base_url = "https://{{merchant_endpoint_prefix}}.3ds-server.prev.netcetera-cloud-payment.ch"
nexinets.base_url = "https://apitest.payengine.de/v1"
nexixpay.base_url = "https://xpaysandbox.nexigroup.com/api/phoenix-0.0/psp/api/v1"
nomupay.base_url = "https://payout-api.sandbox.nomupay.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the alphabetical here

config/docker_compose.toml Outdated
@@ -247,6 +248,7 @@ cards = [
"netcetera",
"nexinets",
"nexixpay",
"nomupay",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

crates/hyperswitch_interfaces/src/configs.rs Outdated
@@ -53,6 +53,7 @@ pub struct Connectors {
pub netcetera: ConnectorParams,
pub nexinets: ConnectorParams,
pub nexixpay: ConnectorParams,
pub nomupay: ConnectorParams,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

loadtest/config/development.toml Outdated
@@ -213,6 +214,7 @@ cards = [
"netcetera",
"nexinets",
"nexixpay",
"nomupay",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@sumanmaji4 sumanmaji4 force-pushed the nomupay_payouts_connector_template branch from 95857f2 to 51c9e21 Compare October 23, 2024 07:55
@hyperswitch-bot hyperswitch-bot bot added M-api-contract-changes Metadata: This PR involves API contract changes and removed M-api-contract-changes Metadata: This PR involves API contract changes labels Oct 23, 2024
@sumanmaji4 sumanmaji4 requested a review from cookieg13 October 23, 2024 09:28
cookieg13
cookieg13 previously approved these changes Oct 23, 2024
View reviewed changes
@sumanmaji4 sumanmaji4 force-pushed the nomupay_payouts_connector_template branch from adf5a81 to a2d8841 Compare October 24, 2024 08:31
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Oct 24, 2024
@sumanmaji4 sumanmaji4 force-pushed the nomupay_payouts_connector_template branch from a2d8841 to 5ea5cc6 Compare October 24, 2024 09:02
@sumanmaji4 sumanmaji4 dismissed stale reviews from deepanshu-iiitu and cookieg13 via 308a230 November 6, 2024 10:54
@sumanmaji4 sumanmaji4 force-pushed the nomupay_payouts_connector_template branch from 0680bdd to 308a230 Compare November 6, 2024 10:54
@hyperswitch-bot hyperswitch-bot bot added M-api-contract-changes Metadata: This PR involves API contract changes and removed M-api-contract-changes Metadata: This PR involves API contract changes labels Nov 6, 2024
SanchithHegde
SanchithHegde previously approved these changes Nov 6, 2024
View reviewed changes
cookieg13
cookieg13 previously approved these changes Nov 7, 2024
View reviewed changes
@sumanmaji4 sumanmaji4 force-pushed the nomupay_payouts_connector_template branch from 44c632c to 689f364 Compare November 10, 2024 07:40
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Nov 10, 2024
@hyperswitch-bot hyperswitch-bot bot removed the M-api-contract-changes Metadata: This PR involves API contract changes label Nov 10, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 20a3a1c Nov 12, 2024
16 of 17 checks passed
@likhinbopanna likhinbopanna deleted the nomupay_payouts_connector_template branch November 12, 2024 07:30
bsayak03 pushed a commit that referenced this pull request Nov 26, 2024
@sumanmaji4 @hyperswitch-bot
feat(connector): [NOMUPAY] Add template code (#6382)
22c9424 
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
bsayak03 pushed a commit that referenced this pull request Nov 26, 2024
@sumanmaji4 @hyperswitch-bot
feat(connector): [NOMUPAY] Add template code (#6382)
11c89cc 
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cookieg13 cookieg13 cookieg13 approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@dracarys18 dracarys18 dracarys18 approved these changes

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@SanchithHegde SanchithHegde SanchithHegde left review comments

Assignees

@sumanmaji4 sumanmaji4

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sumanmaji4 @ImSagnik007 @ArjunKarthik @SanchithHegde @deepanshu-iiitu @dracarys18 @sai-harsha-vardhan @cookieg13 @likhinbopanna